display all ads in the database, remove user setting
MacRonin - February 1, 2008 - 17:35
| Project: | Text Link Ads Integration |
| Version: | 5.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
I'm not sure if this is a bug or a feature ;-)
It seems that occasion TLA overbooks an advertising slot. When it does so, the TLA module(here in Drupal land) only displays the official amount.
I had my site setup to sell and also display 6 ads. Somehow (probably cause an old advertiser dropped out and two were booked to replace it) But since I had the module configed to display 6 ads, that is all it displayed. I also saw no indication of an error msg on the admin page.
I upped the display count to 8 and it now displays all 7 off the ads
#1
I've been bitten by this before as well - http://drupal.org/node/230797
I think you are right, perhaps the module should just show every ad in the database for an XML key and not worry about limiting itself. This is even more important in the case of multiple xml keys where, perhaps, you want 4 links on the home page and 6 on a sub page - there is no way to do that in the current UI but if we lifted the restriction then it would work fine.
#2
As I think about this more, it really shouldn't even be a setting on the admin page - that just clutters the UI unnecessarily.