Update D6 branch to work with View2 RC3

sirkitree - September 28, 2008 - 19:29
Project:Node comments
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Description

Views2 RC2 brought a few major changes to the system that module maintainers need to utilize in order to make their contributed modules compatible with it. See here for details: http://www.angrydonuts.com/attention-views-api-developers

Any help would be appreciated.

#1

vbala - September 29, 2008 - 13:57
Status:active» needs review

Hi sirkitree!
I created a patch based on the documentation you linked in. It seems to work with Views2 RC3.

I tested only the basic functionality: it shows comments below the node and you can change the comment view between 'nodecomments' or 'nodecomment_threaded'. I haven't tried editing these views by the Views UI yet because they work for me.

Note: two patches are attached because I diffed first with the CVS version but realized that the issue is for the 6.x-1.x-dev.

AttachmentSize
nodecomment-dev_views2rc3.patch 39.84 KB
nodecomment-cvs_views2rc3.patch 37.88 KB

#2

sirkitree - September 29, 2008 - 14:02
Status:needs review» fixed

Thanks vbala. Your patch did not apply very cleanly, but I managed to sort out exactly what it was doing. The big help was the file creation. This has been committed to DRUPAL-6--1 branch, which (please note) is the same as the 6.x-1.x-dev

#3

sirkitree - September 29, 2008 - 14:03
Title:Update D6 branch to work with View2 RC2» Update D6 branch to work with View2 RC3

#4

vbala - September 29, 2008 - 14:09

Sorry for the confusion, this has been my first patch.
It's good to see that it helped some :)

#5

kjpil - September 29, 2008 - 19:22

thanks for making this patch. Unfortunatly Im to stupit to get it to work, but I am desperate to get it to work, my site is broken and it causes problem to downgrade views and cck at my site.

I did remove all + signes replacing the code in the exsisting files, as well as adding the hook_views_api to module file, also creating this new files in nodecomment/views directory that I did not have before. But I still cant find the comments at my site. Would it be possible to get instructions how to use the patch to get it to work?

#6

sirkitree - September 30, 2008 - 05:26

#7

kjpil - September 30, 2008 - 11:25

thanks!! saved my day, now my website runs smooth again :)

#8

Anonymous (not verified) - October 14, 2008 - 11:31
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.