Incorrect function parameters passed to signup_pay_adjust from signup_pay_do_paypal
carlosdavis - October 21, 2008 - 06:23
| Project: | Signup Pay for a node |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Jump to:
Description
I was noticing that signup_pay_adjust was not working properly to generate the Paypal link in signup_pay_do_paypal.
On line 869:
$amount = signup_pay_adjust($node, $user, $amount);
Neither $node nor $user have been set. Instead the function call should be using $signup_node and $signup_user, as vivified 9 lines above.
I replaced 869 with:
$amount = signup_pay_adjust($signup_node, $signup_user, $amount);
Has this issue already been discussed elsewhere? Should I finally get involved on the CVS side of things and commit this change?

#1
You need to submit your fix as a properly formatted patch against the 5.x-1.x-dev tarball.
Check http://drupal.org/patch for details.
#2
While I am not testing the uid (events for anonymous users), the nid seems to be working fine for me without changing the code. (Since this is a stale issue, I checked the code and it hasn't been changed.)