Share widget appears in wrong location
Gribnif - June 16, 2009 - 18:13
| Project: | Share |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Jump to:
Description
Firefox 3 on Windows seems to be hitting the Drupal.SharePlugin.migrate function too soon. As a result, if the page contains a bunch of images, the widget opens up in the wrong location on the page. I think this is because the code that sets its location is being called before all of the images have loaded.
The solution is to call the positioning code when the user actually clicks on the activation link. See the attached patch.
| Attachment | Size |
|---|---|
| share_widget_link-race-cond.patch | 782 bytes |
#1
Cool!
Works really great and solves a persistent issue with Share.
To be more explicit the problem with the widget location was happening in IE7, Safari, Chrome and FF, with this patch I have tested that works fine with Safari, Chrome, FF and with IE.