Preview doesn't work on non-english sites

ankheg - June 25, 2009 - 19:03
Project:Comment Upload
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Issue tags:attach, preview
Description

Preview doesn't work on non-english sites, because some strings aren't wrapped in t().

String 538 'Attach'
String 556 'Preview' and 'Attach'

#1

toemaz - July 4, 2009 - 18:10
Version:6.x-1.0-alpha5» 6.x-1.x-dev
Status:active» needs review

I had the same problem.
Find the patch attached.

AttachmentSize
comment_upload_preview.patch 1.44 KB

#2

toemaz - July 6, 2009 - 15:26

@ankheg I made a patch based on your initial post but I didn't get it to work yet. Have you been able to actually solve the issue or was your proposed solution just a hunch?

#3

ankheg - July 9, 2009 - 20:26

Yes, the problem's solved. Your patch seems ok.

#4

netaustin - July 14, 2009 - 20:01
Status:needs review» fixed

Patch looks good. Committed, thanks!

#5

System Message - July 28, 2009 - 20:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

#6

EllECTRONC - August 14, 2009 - 21:53

This patch works great! Thanx toemaz.

#7

lewmich - September 18, 2009 - 07:23

Problem came back after updating Drupal to 6.14... It is weird because I have the newest Comment Upload module with patch commited... Someting else changed?

m.

#8

toemaz - September 18, 2009 - 07:28

@lewmich
It has been committed: http://drupal.org/cvs?commit=237422 and so it's available in the D6 dev package.

#9

EllECTRONC - September 26, 2009 - 20:15
Status:closed» active

updating Drupal to 6.14 and problem came back...
tested: 6.x-1.0-alpha5, 6.x-1.x-dev

No preview if text olny and if text and attach

don't wanna back to 6.13...

#10

toemaz - September 26, 2009 - 20:19
Status:active» closed

There has been an FAPI change in 6.14. See for similar bug report http://drupal.org/node/579900
This 'new' issue has nothing to do with this one so resubmit a new issue.

 
 

Drupal is a registered trademark of Dries Buytaert.