Patch spotlight: daylight saving time for Drupal

Help us test patches for core! This page will feature important core patches that need to be reviewed and tested. You can help with this important task even if you don't know how to code.

NOTE: This page just contains information about the current highest-priority core effort. For many more, check out Patch Spotlight 2.0

Currently in the spotlight: introduce daylight saving time for Drupal

#11077: Introduce Daylight Saving Time for Drupal
This patch adds support for daylight saving time, meaning users will get correct time representation in Drupal throughout the year.

For a synopsis of changes see: http://drupal.org/node/11077#comment-1053509

How to test this patch

Test the my account page, autodetection etc.

What do I do if I find a bug while testing a patch?

Try to reproduce the bug on a 'clean' copy of Drupal HEAD. For patches without database changes, you can "reverse" apply a patch to remove it:

For patches that make changes to the database, you'll need a clean checkout elsewhere to compare against.

Check to see if the bug manifests itself without the patch. And note: don't forget to re-apply afterwards:

If not, it's usually safe to assume it's caused by the current patch. Mark the issue "code needs work" and describe in detail what you experienced and how the developer can re-produce the steps.

If so, then there is a deeper problem with core... see if someone has already reported a bug on it by searching the issue queue. If not, feel free to file a bug.

General patch reviewing tips

Here is a list of general resources for applying and testing patches.

• HOW TO: Set up a test environment to help review patches: First thing's first: get a development environment setup to perform your testing. This requires a CVS checkout (not a CVS account!), a web environment with Apache, MySQL, and PHP, and the 'diff' and 'patch' utilities. More specific information can be found at the following pages:
  • CVS Clients
  • Get a copy of Drupal HEAD from CVS
• HOW TO: Apply Patches: This is where the action starts. For visual learners, there is also Video: Applying Patches to Drupal Core
• Tips for reviewing patches: Some best practice guidelines on what makes up a good patch review.
• HOWTO: Benchmark Drupal code: Some changes are extensive and require performance benchmarking in order to make it into core. Learn more about it here.
• There is also a Reviewers group, a group of folks dedicated to doing patch reviews who would be happy to answer your questions!